Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1900003002: Add a dummy //:chromium_builder_tests to the GN build. (Closed)

Created:
4 years, 8 months ago by Dirk Pranke
Modified:
4 years, 8 months ago
Reviewers:
brettw, brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a dummy //:chromium_builder_tests to the GN build. Apparently some bots still use this target to build targets, if they're not building a specific list of tests. TBR=brettw@chromium.org, brucedawson@chromium.org BUG=581899 NOTRY=true Committed: https://chromium.googlesource.com/chromium/src/+/f00b78ba8c4843cda09d98af0730565888d0532c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Dirk Pranke
TBR'ing because this is a build fix; NOTRY'ing because the try jobs aren't going to ...
4 years, 8 months ago (2016-04-18 23:54:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900003002/1
4 years, 8 months ago (2016-04-18 23:55:05 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f00b78ba8c4843cda09d98af0730565888d0532c Cr-Commit-Position: refs/heads/master@{#388083}
4 years, 8 months ago (2016-04-19 00:01:32 UTC) #7
Dirk Pranke
Committed patchset #1 (id:1) manually as f00b78ba8c4843cda09d98af0730565888d0532c (tree was closed).
4 years, 8 months ago (2016-04-19 00:02:28 UTC) #9
brettw
4 years, 8 months ago (2016-04-19 05:16:56 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698