Issue 19000004: add ability to specify the DPI at which to render the page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19000004: add ability to specify the DPI at which to render the page (Closed)

Created:
7 years, 5 months ago by edisonn

Modified:
7 years, 5 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

add ability to specify the DPI at which to render the page Committed: https://code.google.com/p/skia/source/detail?r=10009

Patch Set 1 #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -17 lines)			Patch
M	experimental/PdfViewer/SkPdfRenderer.h	View	2 chunks	+2 lines, -1 line	2 comments	Download
M	experimental/PdfViewer/SkPdfRenderer.cpp	View	3 chunks	+10 lines, -9 lines	0 comments	Download
M	experimental/PdfViewer/pdf_viewer_main.cpp	View	2 chunks	+11 lines, -6 lines	0 comments	Download
M	samplecode/SamplePdfFileViewer.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

reed1

https://codereview.chromium.org/19000004/diff/1/experimental/PdfViewer/SkPdfRenderer.h File experimental/PdfViewer/SkPdfRenderer.h (right): https://codereview.chromium.org/19000004/diff/1/experimental/PdfViewer/SkPdfRenderer.h#newcode24 experimental/PdfViewer/SkPdfRenderer.h:24: bool renderPage(int page, SkCanvas* canvas, const SkRect& dst) const; ...

7 years, 5 months ago (2013-07-11 15:27:13 UTC) #2

edisonn

7 years, 5 months ago (2013-07-11 15:36:24 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/19000004/diff/1/experimental/PdfViewer/SkPdfR...
File experimental/PdfViewer/SkPdfRenderer.h (right):

https://codereview.chromium.org/19000004/diff/1/experimental/PdfViewer/SkPdfR...
experimental/PdfViewer/SkPdfRenderer.h:24: bool renderPage(int page, SkCanvas*
canvas, const SkRect& dst) const;
On 2013/07/11 15:27:13, reed1 wrote:
> Why is this better than just using the matrix on the canvas?

there is some magic I need to do to remap the matrix, since in pdf the (0,0) is
on the bottom left, unlike skia where is top left. I rather have the magic in
the renderpage, rather than any caller to have to implement it.

If I get rid of it, then we can use the matrix

Expand Messages | Collapse Messages