Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 1899953002: Enable DART_PRECOMPILER on all platforms so AOT compilation can be used on Android (Closed)

Created:
4 years, 8 months ago by jsimmons1
Modified:
4 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://chromium.googlesource.com/external/github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable DART_PRECOMPILER on all platforms so AOT compilation can be used on Android BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/d1c044c5a1609a14a52678740b0967bae91904f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M runtime/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
jsimmons1
4 years, 8 months ago (2016-04-18 22:08:10 UTC) #2
rmacnak
LGTM (Noting for posterity that we measured ~10kB increase in binary size on Android.)
4 years, 8 months ago (2016-04-18 22:25:53 UTC) #3
rmacnak
4 years, 8 months ago (2016-04-19 00:03:16 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1c044c5a1609a14a52678740b0967bae91904f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698