Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 189993003: Disable PnaclDebugURLFlag*L on windows. (Closed)

Created:
6 years, 9 months ago by jvoung (off chromium)
Modified:
6 years, 9 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Disable PnaclDebugURLFlag* on windows. Only really need to disable on 32-bit windows, but disable on all for now. It uses debug stub which does not play well with sandbox reservation on 32-bit. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3765 TBR=bradnelson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255535

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/test/nacl/nacl_browsertest.cc View 1 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jvoung (off chromium)
Committed patchset #2 manually as r255535 (tree was closed).
6 years, 9 months ago (2014-03-07 05:53:32 UTC) #1
bradn
6 years, 9 months ago (2014-03-07 22:32:41 UTC) #2
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698