Added a uploadsdk python script.

pkg/docgen/bin/uploadsdk.py

+#!/usr/bin/env python
+#
+# Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+# for details. All rights reserved. Use of this source code is governed by a
+# BSD-style license that can be found in the LICENSE file.
+
+import platform
+import subprocess
+import sys
+sys.path.insert(0, '../../../tools')

[Emily Fortuna, 2013/07/10 21:23:32]

sys.path.append(and then again, get an absolute path)

+import utils
+

[Emily Fortuna, 2013/07/10 21:23:32]

please add a doc comment """...""" explaining how this file is used.

+DART = '../../../' + utils.BUILD_ROOT[utils.GuessOS()] \

[Emily Fortuna, 2013/07/10 21:23:32]

absolute path is better than a relative path because on our buildbots, the
checkout is on a non-local drive and also then yo can run this script while
standing in any location, instead of only in the same directory as this script.
Regardless, call utils.DartBinary() or utils.DartSdkBinary() instead.

+  + '/ReleaseIA32/dart-sdk/bin/dart'

[Emily Fortuna, 2013/07/10 21:23:32]

+2 spaces. Also you can group this in () instead of \ 
See http://www.chromium.org/developers/coding-style for Python style guidelines.

[janicejl, 2013/07/11 00:02:08]

Done.

+GSUTIL = '../../../third_party/gsutil/gsutil'

[Emily Fortuna, 2013/07/10 21:23:32]

please create an absoulte path instead.

[janicejl, 2013/07/11 00:02:08]

Done.

+HAS_SHELL = False
+if platform.system() == 'Windows':
+  HAS_SHELL = True
+GS_SITE = 'gs://dartlang-docgen'
+
+def ExecuteCommand(cmd):

[Emily Fortuna, 2013/07/10 21:23:32]

isn't this function defined in the utils file? If so, can we just call that?

[janicejl, 2013/07/11 00:02:08]

No it is not in the utils file, it is in upload_sdk.py in the same folder as
util. 

+  # Execute a command in a subprocess.

[Emily Fortuna, 2013/07/10 21:23:32]

Doc comments for python are triple quotes """blah """

[janicejl, 2013/07/11 00:02:08]

Done.

+  print 'Executing: ' + ' '.join(cmd)
+  pipe = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE,
+      shell=HAS_SHELL)
+  output = pipe.communicate()
+  if pipe.returncode != 0:
+    print 'Execution failed: ' + str(output)
+  return (pipe.returncode, output)
+
+def main(argv):

[Emily Fortuna, 2013/07/10 21:23:32]

no need to pass argument if it's not used.

def main(): 

[janicejl, 2013/07/11 00:02:08]

Done.

+  # Execute Docgen.dart on the SDK. 
+  ExecuteCommand([DART, 'docgen.dart', '--include-private', '--parse-sdk'])
+  
+  # Use SVN Revision to get the revision number. 
+  revision = utils.GetSVNRevision()
+  if revision is None:
+    sys.stderr.write('Unable to find revision. \n')
+    return 1

[Emily Fortuna, 2013/07/10 21:23:32]

throw exception here instead? No point in continuing:
"raise Exception("unable to find....")"

[janicejl, 2013/07/11 00:02:08]

Done.

+
+  # Upload the all files in Docs into a folder based off Revision number on 
+  # Cloud Storage. 
+  ExecuteCommand([GSUTIL, '-m', 'cp', '-q', '-a', 'public-read', '-r',
+    './docs/*', GS_SITE + '/' + revision + '/'])
+
+  # Update VERSION file in Cloud Storage. 
+  with open('VERSION', 'w') as version_file:
+    version_file.write(revision);
+  ExecuteCommand([GSUTIL, '-m', 'cp', '-q', '-a', 'public-read', './VERSION',
+    GS_SITE + '/VERSION'])
+
+if __name__ == '__main__':
+  sys.exit(main(sys.argv))

[Emily Fortuna, 2013/07/10 21:23:32]

it will automatically exit after calling main. Just write this:


if __name__ == '__main__':
  main()

[janicejl, 2013/07/11 00:02:08]

Done.