Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

Issue 1899893003: [Devtools] JSONView implements Searchable interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
index 5c77d9ee6aacc72c2ff05f885ed370fc90bd6c6a..f7896b9d371404689d2c66ea4a617c705e23c04e 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
@@ -74,9 +74,18 @@ WebInspector.RequestPreviewView.prototype = {
toolbar.appendToolbarItem(item);
}
this.innerView = this._previewView;
+ this._previewViewHandledForTest(this._previewView);
}
},
+ /**
+ * @param {!WebInspector.Widget} view
+ */
+ _previewViewHandledForTest: function(view) { },
+
+ /**
+ * @return {!WebInspector.EmptyWidget}
+ */
_createEmptyWidget: function()
{
return this._createMessageView(WebInspector.UIString("This request has no preview available."));
@@ -102,13 +111,13 @@ WebInspector.RequestPreviewView.prototype = {
/**
* @param {?WebInspector.ParsedJSON} parsedJSON
- * @return {?WebInspector.JSONView}
+ * @return {?WebInspector.SearchableView}
*/
_jsonView: function(parsedJSON)
{
if (!parsedJSON || typeof parsedJSON.data !== "object")
return null;
- return new WebInspector.JSONView(/** @type {!WebInspector.ParsedJSON} */ (parsedJSON));
+ return WebInspector.JSONView.createSearchableView(/** @type {!WebInspector.ParsedJSON} */ (parsedJSON));
},
/**

Powered by Google App Engine
This is Rietveld 408576698