Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

Issue 1899893003: [Devtools] JSONView implements Searchable interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js b/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
index c09084858f60b23a5b83d39d81f8ac866edc3435..b8d04875f5c45395704756a7f6bc76a5c307e38f 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js
@@ -102,13 +102,13 @@ WebInspector.RequestPreviewView.prototype = {
/**
* @param {?WebInspector.ParsedJSON} parsedJSON
- * @return {?WebInspector.JSONView}
+ * @return {?WebInspector.SearchableView}
*/
_jsonView: function(parsedJSON)
{
if (!parsedJSON || typeof parsedJSON.data !== "object")
return null;
- return new WebInspector.JSONView(/** @type {!WebInspector.ParsedJSON} */ (parsedJSON));
+ return WebInspector.JSONView.createSearchableView(/** @type {!WebInspector.ParsedJSON} */ (parsedJSON));
},
/**
@@ -148,8 +148,10 @@ WebInspector.RequestPreviewView.prototype = {
}
var xmlView = this._xmlView();
- if (xmlView)
- return xmlView;
+ if (xmlView) {
+ callback(xmlView);
lushnikov 2016/04/26 19:22:03 looks like a fix for a regression! Let's land this
allada 2016/04/27 21:19:57 Done.
+ return;
+ }
WebInspector.JSONView.parseJSON(this._requestContent()).then(chooseView.bind(this)).then(callback);

Powered by Google App Engine
This is Rietveld 408576698