third_party/WebKit/LayoutTests/http/tests/inspector/network/json-preview.html - Issue 1899893003: [Devtools] JSONView implements Searchable interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/http/tests/inspector/network/json-preview.html

Issue 1899893003: [Devtools] JSONView implements Searchable interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/inspector/network/json-preview-expected.txt » ('j') | third_party/WebKit/Source/devtools/front_end/components/ObjectPropertiesSection.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/http/tests/inspector/network/json-preview.html

diff --git a/third_party/WebKit/LayoutTests/http/tests/inspector/network/json-preview.html b/third_party/WebKit/LayoutTests/http/tests/inspector/network/json-preview.html

index 576ae9322fac1868e345c3bf721ff218f56ad9db..f42f98c18f590f6ccafe328b098756e472da2176 100644

--- a/third_party/WebKit/LayoutTests/http/tests/inspector/network/json-preview.html

+++ b/third_party/WebKit/LayoutTests/http/tests/inspector/network/json-preview.html

@@ -20,7 +20,8 @@ function test()

var previewView = new WebInspector.RequestPreviewView(request, null);

previewView._createPreviewView(function(previewer) {

- InspectorTest.addResult("Its previewer is the JSON previewer: " + (previewer && previewer instanceof WebInspector.JSONView));

+ InspectorTest.addResult("Its previewer is searchable: " + (previewer && previewer instanceof WebInspector.SearchableView));

lushnikov 2016/04/22 19:43:00 lets write a test that does actual search. (You ca

allada 2016/04/25 23:48:48 Done.

+ InspectorTest.addResult("Its previewer is the JSON previewer: " + (previewer && previewer._searchProvider && previewer._searchProvider instanceof WebInspector.JSONView));

done();

});