[Devtools] JSONView implements Searchable interface

third_party/WebKit/Source/devtools/front_end/network/RequestPreviewView.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 84 matching lines @@
      * @return {string}
      */
     _requestContent: function()
     {
         var content = this.request.content;
         return this.request.contentEncoded ? window.atob(content || "") : (content || "");
     },
 
     /**
      * @param {?WebInspector.ParsedJSON} parsedJSON
-     * @return {?WebInspector.JSONView}
+     * @return {?WebInspector.SearchableView}
      */
     _jsonView: function(parsedJSON)
     {
         if (!parsedJSON || typeof parsedJSON.data !== "object")
             return null;
-        return new WebInspector.JSONView(/** @type {!WebInspector.ParsedJSON} */ (parsedJSON));
+        return WebInspector.JSONView.createSearchableView(/** @type {!WebInspector.ParsedJSON} */ (parsedJSON));
     },
 
     /**
      * @return {?WebInspector.XMLView}
      */
     _xmlView: function()
     {
         var content = this._requestContent();
         var parsedXML = WebInspector.XMLView.parseXML(content, this.request.mimeType);
         return parsedXML ? new WebInspector.XMLView(parsedXML) : null;
@@ skipping 19 matching lines @@
      * @param {function(!WebInspector.Widget)} callback
      */
     _createPreviewView: function(callback)
     {
         if (this.request.contentError()) {
             callback(this._createMessageView(WebInspector.UIString("Failed to load response data")));
             return;
         }
 
         var xmlView = this._xmlView();
-        if (xmlView)
-            return xmlView;
+        if (xmlView) {
+            callback(xmlView);

[lushnikov, 2016/04/26 19:22:03]

looks like a fix for a regression! Let's land this fix separately.

[allada, 2016/04/27 21:19:57]

Done.

+            return;
+        }
 
         WebInspector.JSONView.parseJSON(this._requestContent()).then(chooseView.bind(this)).then(callback);
 
         /**
          * @this {WebInspector.RequestPreviewView}
          * @param {?WebInspector.ParsedJSON} jsonData
          * @return {!WebInspector.Widget}
          */
         function chooseView(jsonData)
         {
@@ skipping 14 matching lines @@
 
             if (this.request.resourceType() === WebInspector.resourceTypes.Other)
                 return this._createEmptyWidget();
 
             return WebInspector.RequestView.nonSourceViewForRequest(this.request);
         }
     },
 
     __proto__: WebInspector.RequestContentView.prototype
 }