components/autofill/core/browser/autofill_metrics_unittest.cc - Issue 1899893002: Card unmasking without form filling

Unified Diff: components/autofill/core/browser/autofill_metrics_unittest.cc

Issue 1899893002: Card unmasking without form filling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use the credit card number field in metrics tests, because ios single-field form fill will not requ… Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_manager_unittest.cc ('k') | components/autofill/core/browser/payments/full_card_request.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_metrics_unittest.cc

diff --git a/components/autofill/core/browser/autofill_metrics_unittest.cc b/components/autofill/core/browser/autofill_metrics_unittest.cc

index a01b78f9ae83ccd3de9c7de11acf39a29f7a1126..472746f32563893f1f42ada15b8ed472eb190e7b 100644

--- a/components/autofill/core/browser/autofill_metrics_unittest.cc

+++ b/components/autofill/core/browser/autofill_metrics_unittest.cc

@@ -1882,7 +1882,7 @@ TEST_F(AutofillMetricsTest, CreditCardFilledFormEvents) {

std::string guid(

"10000000-0000-0000-0000-000000000002"); // masked server card

autofill_manager_->FillOrPreviewForm(

- AutofillDriver::FORM_DATA_ACTION_FILL, 0, form, form.fields.front(),

+ AutofillDriver::FORM_DATA_ACTION_FILL, 0, form, form.fields.back(),

autofill_manager_->MakeFrontendID(guid, std::string()));

autofill_manager_->OnDidGetRealPan(AutofillClient::SUCCESS,

"6011000990139424");

@@ -1981,7 +1981,7 @@ TEST_F(AutofillMetricsTest, CreditCardGetRealPanDuration) {

// Masked server card.

std::string guid("10000000-0000-0000-0000-000000000002");

autofill_manager_->FillOrPreviewForm(

- AutofillDriver::FORM_DATA_ACTION_FILL, 0, form, form.fields.front(),

+ AutofillDriver::FORM_DATA_ACTION_FILL, 0, form, form.fields.back(),

autofill_manager_->MakeFrontendID(guid, std::string()));

autofill_manager_->OnDidGetRealPan(AutofillClient::SUCCESS,

"6011000990139424");

@@ -2006,7 +2006,7 @@ TEST_F(AutofillMetricsTest, CreditCardGetRealPanDuration) {

// Masked server card.

std::string guid("10000000-0000-0000-0000-000000000002");

autofill_manager_->FillOrPreviewForm(

- AutofillDriver::FORM_DATA_ACTION_FILL, 0, form, form.fields.front(),

+ AutofillDriver::FORM_DATA_ACTION_FILL, 0, form, form.fields.back(),

autofill_manager_->MakeFrontendID(guid, std::string()));

autofill_manager_->OnDidGetRealPan(AutofillClient::PERMANENT_FAILURE,

std::string());

@@ -2113,7 +2113,7 @@ TEST_F(AutofillMetricsTest, CreditCardSubmittedFormEvents) {

std::string guid(

"10000000-0000-0000-0000-000000000002"); // masked server card

autofill_manager_->FillOrPreviewForm(

- AutofillDriver::FORM_DATA_ACTION_FILL, 0, form, form.fields.front(),

+ AutofillDriver::FORM_DATA_ACTION_FILL, 0, form, form.fields.back(),

autofill_manager_->MakeFrontendID(guid, std::string()));

autofill_manager_->OnDidGetRealPan(AutofillClient::SUCCESS,

"6011000990139424");

@@ -2300,7 +2300,7 @@ TEST_F(AutofillMetricsTest, CreditCardWillSubmitFormEvents) {

// Masked server card.

std::string guid("10000000-0000-0000-0000-000000000002");

autofill_manager_->FillOrPreviewForm(

- AutofillDriver::FORM_DATA_ACTION_FILL, 0, form, form.fields.front(),

+ AutofillDriver::FORM_DATA_ACTION_FILL, 0, form, form.fields.back(),

autofill_manager_->MakeFrontendID(guid, std::string()));

autofill_manager_->OnDidGetRealPan(AutofillClient::SUCCESS,

"6011000990139424");