components/autofill/core/browser/autofill_external_delegate_unittest.cc - Issue 1899893002: Card unmasking without form filling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate_unittest.cc

Issue 1899893002: Card unmasking without form filling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use the credit card number field in metrics tests, because ios single-field form fill will not requ… Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_external_delegate.cc ('k') | components/autofill/core/browser/autofill_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_external_delegate_unittest.cc

diff --git a/components/autofill/core/browser/autofill_external_delegate_unittest.cc b/components/autofill/core/browser/autofill_external_delegate_unittest.cc

index 0349cb5fea5ed2b2e2e2751f192b5021794e775e..782f07c22620b025d15d4125b07c32266b7da362 100644

--- a/components/autofill/core/browser/autofill_external_delegate_unittest.cc

+++ b/components/autofill/core/browser/autofill_external_delegate_unittest.cc

@@ -98,11 +98,12 @@ class MockAutofillManager : public AutofillManager {

const FormFieldData& field,

int unique_id));

- MOCK_METHOD4(FillCreditCardForm,

+ MOCK_METHOD5(FillCreditCardForm,

void(int query_id,

const FormData& form,

const FormFieldData& field,

- const CreditCard& credit_card));

+ const CreditCard& credit_card,

+ const base::string16& cvc));

private:

DISALLOW_COPY_AND_ASSIGN(MockAutofillManager);

@@ -573,7 +574,8 @@ TEST_F(AutofillExternalDelegateUnitTest, FillCreditCardForm) {

EXPECT_CALL(*autofill_manager_,

FillCreditCardForm(

_, _, _, CreditCardMatches(card_number, expiration_month,

- expiration_year)));

+ expiration_year),

+ base::string16()));

external_delegate_->OnCreditCardScanned(card_number, expiration_month,

expiration_year);

}