Card unmasking without form filling

components/autofill/core/browser/full_card_request.cc

Index: components/autofill/core/browser/full_card_request.cc
diff --git a/components/autofill/core/browser/full_card_request.cc b/components/autofill/core/browser/full_card_request.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9317a4938d73b027cd57e7b1ef77efb82c49d96c
--- /dev/null
+++ b/components/autofill/core/browser/full_card_request.cc
@@ -0,0 +1,142 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/autofill/core/browser/full_card_request.h"
+
+#include "base/bind.h"
+#include "base/logging.h"
+#include "base/strings/utf_string_conversions.h"
+#include "components/autofill/core/browser/autofill_client.h"
+#include "components/autofill/core/browser/autofill_metrics.h"
+#include "components/autofill/core/browser/credit_card.h"
+#include "components/autofill/core/browser/personal_data_manager.h"
+
+namespace autofill {
+
+FullCardRequest::FullCardRequest(net::URLRequestContextGetter* url_getter,
+                                 AutofillClient* autofill_client,
+                                 PersonalDataManager* personal_data_manager)
+    : autofill_client_(autofill_client),
+      personal_data_manager_(personal_data_manager),
+      delegate_(nullptr),
+      payments_client_(url_getter, this),

[Mathieu, 2016/04/22 17:58:35]

could PaymentsClient be an argument to the constructor? We already have one in
AutofillManager (haven't looked in other places).

[please use gerrit instead, 2016/04/22 20:50:18]

Done.

+      weak_ptr_factory_(this) {
+  DCHECK(autofill_client_);
+  DCHECK(personal_data_manager_);
+}
+
+FullCardRequest::~FullCardRequest() {}
+
+void FullCardRequest::GetFullCard(const CreditCard& card,
+                                  AutofillClient::UnmaskCardReason reason,
+                                  base::WeakPtr<Delegate> delegate) {
+  DCHECK(delegate);
+  if (delegate_) {

[Mathieu, 2016/04/22 17:58:35]

Please add a comment since this is not immediately clear to the reader
(delegate_ vs delegate)

[please use gerrit instead, 2016/04/22 20:50:18]

Done.

+    delegate->OnFullCardError();
+    return;
+  }
+
+  delegate_ = delegate;
+  request_.reset(new payments::PaymentsClient::UnmaskRequestDetails);
+  request_->card = card;
+  bool is_masked = card.record_type() == CreditCard::MASKED_SERVER_CARD;
+  if (is_masked)
+    payments_client_.Prepare();
+
+  autofill_client_->ShowUnmaskPrompt(request_->card, reason,
+                                     weak_ptr_factory_.GetWeakPtr());
+
+  if (is_masked) {
+    autofill_client_->LoadRiskData(
+        base::Bind(&FullCardRequest::OnDidGetUnmaskRiskData,
+                   weak_ptr_factory_.GetWeakPtr()));
+  }
+}
+
+bool FullCardRequest::IsGettingFullCard() const {
+  return !!request_;
+}
+
+void FullCardRequest::OnDidGetUnmaskRiskData(const std::string& risk_data) {
+  request_->risk_data = risk_data;
+  if (!request_->user_response.cvc.empty()) {
+    real_pan_request_timestamp_ = base::Time::Now();
+    payments_client_.UnmaskCard(*request_);
+  }
+}
+
+void FullCardRequest::OnUnmaskResponse(const UnmaskResponse& response) {
+  if (!response.exp_month.empty())
+    request_->card.SetRawInfo(CREDIT_CARD_EXP_MONTH, response.exp_month);
+
+  if (!response.exp_year.empty())
+    request_->card.SetRawInfo(CREDIT_CARD_EXP_4_DIGIT_YEAR, response.exp_year);
+
+  if (request_->card.record_type() != CreditCard::MASKED_SERVER_CARD) {
+    if (delegate_)
+      delegate_->OnFullCardDetails(request_->card, response.cvc);
+    delegate_ = nullptr;
+    autofill_client_->OnUnmaskVerificationResult(AutofillClient::SUCCESS);
+    request_.reset();
+    return;
+  }
+
+  request_->user_response = response;
+  if (!request_->risk_data.empty()) {
+    real_pan_request_timestamp_ = base::Time::Now();
+    payments_client_.UnmaskCard(*request_);
+  }
+}
+
+void FullCardRequest::OnUnmaskPromptClosed() {
+  if (delegate_)
+    delegate_->OnFullCardError();
+
+  delegate_ = nullptr;
+  payments_client_.CancelRequest();
+  request_.reset();
+}
+
+IdentityProvider* FullCardRequest::GetIdentityProvider() {
+  return autofill_client_->GetIdentityProvider();
+}
+
+void FullCardRequest::OnDidGetRealPan(AutofillClient::PaymentsRpcResult result,
+                                      const std::string& real_pan) {
+  AutofillMetrics::LogRealPanDuration(
+      base::Time::Now() - real_pan_request_timestamp_, result);
+
+  if (!real_pan.empty()) {
+    DCHECK_EQ(AutofillClient::SUCCESS, result);
+    request_->card.set_record_type(CreditCard::FULL_SERVER_CARD);
+    request_->card.SetNumber(base::UTF8ToUTF16(real_pan));
+
+    if (request_->user_response.should_store_pan)
+      personal_data_manager_->UpdateServerCreditCard(request_->card);
+
+    if (delegate_)
+      delegate_->OnFullCardDetails(request_->card, request_->user_response.cvc);
+  } else {
+    if (delegate_)
+      delegate_->OnFullCardError();
+  }
+
+  delegate_ = nullptr;
+  autofill_client_->OnUnmaskVerificationResult(result);
+  request_.reset();
+}
+
+void FullCardRequest::OnDidGetUploadDetails(
+    AutofillClient::PaymentsRpcResult result,
+    const base::string16& context_token,
+    std::unique_ptr<base::DictionaryValue> legal_message) {
+  NOTREACHED();
+}
+
+void FullCardRequest::OnDidUploadCard(
+    AutofillClient::PaymentsRpcResult result) {
+  NOTREACHED();
+}
+
+}  // namespace autofill