Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: components/autofill/core/browser/autofill_metrics_unittest.cc

Issue 1899893002: Card unmasking without form filling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moar tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics_unittest.cc
diff --git a/components/autofill/core/browser/autofill_metrics_unittest.cc b/components/autofill/core/browser/autofill_metrics_unittest.cc
index a01b78f9ae83ccd3de9c7de11acf39a29f7a1126..61dfa61f8a6d2d88700bc4f1e2e6e4818c652f8f 100644
--- a/components/autofill/core/browser/autofill_metrics_unittest.cc
+++ b/components/autofill/core/browser/autofill_metrics_unittest.cc
@@ -1884,8 +1884,8 @@ TEST_F(AutofillMetricsTest, CreditCardFilledFormEvents) {
autofill_manager_->FillOrPreviewForm(
AutofillDriver::FORM_DATA_ACTION_FILL, 0, form, form.fields.front(),
autofill_manager_->MakeFrontendID(guid, std::string()));
- autofill_manager_->OnDidGetRealPan(AutofillClient::SUCCESS,
- "6011000990139424");
+ ((payments::PaymentsClientDelegate*)autofill_manager_->full_card_request())
+ ->OnDidGetRealPan(AutofillClient::SUCCESS, "6011000990139424");
histogram_tester.ExpectBucketCount(
"Autofill.FormEvents.CreditCard",
AutofillMetrics::FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_FILLED, 1);
@@ -1983,8 +1983,8 @@ TEST_F(AutofillMetricsTest, CreditCardGetRealPanDuration) {
autofill_manager_->FillOrPreviewForm(
AutofillDriver::FORM_DATA_ACTION_FILL, 0, form, form.fields.front(),
autofill_manager_->MakeFrontendID(guid, std::string()));
- autofill_manager_->OnDidGetRealPan(AutofillClient::SUCCESS,
- "6011000990139424");
+ ((payments::PaymentsClientDelegate*)autofill_manager_->full_card_request())
+ ->OnDidGetRealPan(AutofillClient::SUCCESS, "6011000990139424");
histogram_tester.ExpectTotalCount(
"Autofill.UnmaskPrompt.GetRealPanDuration", 1);
histogram_tester.ExpectTotalCount(
@@ -2008,8 +2008,8 @@ TEST_F(AutofillMetricsTest, CreditCardGetRealPanDuration) {
autofill_manager_->FillOrPreviewForm(
AutofillDriver::FORM_DATA_ACTION_FILL, 0, form, form.fields.front(),
autofill_manager_->MakeFrontendID(guid, std::string()));
- autofill_manager_->OnDidGetRealPan(AutofillClient::PERMANENT_FAILURE,
- std::string());
+ ((payments::PaymentsClientDelegate*)autofill_manager_->full_card_request())
+ ->OnDidGetRealPan(AutofillClient::PERMANENT_FAILURE, std::string());
histogram_tester.ExpectTotalCount(
"Autofill.UnmaskPrompt.GetRealPanDuration", 1);
histogram_tester.ExpectTotalCount(
@@ -2115,8 +2115,8 @@ TEST_F(AutofillMetricsTest, CreditCardSubmittedFormEvents) {
autofill_manager_->FillOrPreviewForm(
AutofillDriver::FORM_DATA_ACTION_FILL, 0, form, form.fields.front(),
autofill_manager_->MakeFrontendID(guid, std::string()));
- autofill_manager_->OnDidGetRealPan(AutofillClient::SUCCESS,
- "6011000990139424");
+ ((payments::PaymentsClientDelegate*)autofill_manager_->full_card_request())
+ ->OnDidGetRealPan(AutofillClient::SUCCESS, "6011000990139424");
histogram_tester.ExpectBucketCount(
"Autofill.FormEvents.CreditCard",
AutofillMetrics::FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_FILLED, 1);
@@ -2302,8 +2302,8 @@ TEST_F(AutofillMetricsTest, CreditCardWillSubmitFormEvents) {
autofill_manager_->FillOrPreviewForm(
AutofillDriver::FORM_DATA_ACTION_FILL, 0, form, form.fields.front(),
autofill_manager_->MakeFrontendID(guid, std::string()));
- autofill_manager_->OnDidGetRealPan(AutofillClient::SUCCESS,
- "6011000990139424");
+ ((payments::PaymentsClientDelegate*)autofill_manager_->full_card_request())
+ ->OnDidGetRealPan(AutofillClient::SUCCESS, "6011000990139424");
histogram_tester.ExpectBucketCount(
"Autofill.FormEvents.CreditCard",
AutofillMetrics::FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_FILLED, 1);

Powered by Google App Engine
This is Rietveld 408576698