Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/autofill/android/personal_data_manager_android.h

Issue 1899893002: Card unmasking without form filling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moar tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autofill/android/personal_data_manager_android.h
diff --git a/chrome/browser/autofill/android/personal_data_manager_android.h b/chrome/browser/autofill/android/personal_data_manager_android.h
index 61a86b7a33ec888bfe50b4e043c8fe5f1255327c..c244b29962f03bc19b6d0976b507c94427a89b90 100644
--- a/chrome/browser/autofill/android/personal_data_manager_android.h
+++ b/chrome/browser/autofill/android/personal_data_manager_android.h
@@ -8,15 +8,21 @@
#include "base/android/jni_weak_ref.h"
#include "base/android/scoped_java_ref.h"
#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "base/strings/string16.h"
+#include "components/autofill/core/browser/full_card_request.h"
#include "components/autofill/core/browser/personal_data_manager.h"
#include "components/autofill/core/browser/personal_data_manager_observer.h"
namespace autofill {
+class CreditCard;
+
// Android wrapper of the PersonalDataManager which provides access from the
// Java layer. Note that on Android, there's only a single profile, and
// therefore a single instance of this wrapper.
-class PersonalDataManagerAndroid : public PersonalDataManagerObserver {
+class PersonalDataManagerAndroid : public PersonalDataManagerObserver,
+ public FullCardRequest::Delegate {
public:
PersonalDataManagerAndroid(JNIEnv* env, jobject obj);
@@ -97,6 +103,13 @@ class PersonalDataManagerAndroid : public PersonalDataManagerObserver {
const base::android::JavaParamRef<jobject>& unused_obj,
const base::android::JavaParamRef<jstring>& jguid);
+ // Gets the card CVC and the unmasks the card (if it's masked).
Mathieu 2016/04/22 17:58:35 *and unmasks
please use gerrit instead 2016/04/22 20:50:18 Done.
+ void GetFullCardForPaymentRequest(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& unused_obj,
+ const base::android::JavaParamRef<jobject>& web_contents_obj,
+ const base::android::JavaParamRef<jstring>& jguid);
+
// PersonalDataManagerObserver:
void OnPersonalDataChanged() override;
@@ -106,12 +119,19 @@ class PersonalDataManagerAndroid : public PersonalDataManagerObserver {
private:
~PersonalDataManagerAndroid() override;
+ // FullCardRequest::Delegate:
+ void OnFullCardDetails(const CreditCard& card,
+ const base::string16& cvc) override;
+ void OnFullCardError() override;
+
// Pointer to the java counterpart.
JavaObjectWeakGlobalRef weak_java_obj_;
// Pointer to the PersonalDataManager for the main profile.
PersonalDataManager* personal_data_manager_;
+ base::WeakPtrFactory<PersonalDataManagerAndroid> weak_ptr_factory_;
+
DISALLOW_COPY_AND_ASSIGN(PersonalDataManagerAndroid);
};

Powered by Google App Engine
This is Rietveld 408576698