Card unmasking without form filling

components/autofill/core/browser/autofill_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
 
 #include <deque>
 #include <map>
 #include <memory>
@@ skipping 46 matching lines @@
 class AutofillClient;
 class AutofillManagerTestDelegate;
 class AutofillProfile;
 class AutofillType;
 class CreditCard;
 class FormStructureBrowserTest;
 
 struct FormData;
 struct FormFieldData;
 
+// The signature for the callback to be invoked when a card is unmasked.
+using UnmaskCallback = base::Callback<void(
+    bool,  // success
+    const CreditCard&,  // original card
+    const CreditCard&,  // unmasked card
+    const base::string16&)>;  // the cvc for the card
+
 // Manages saving and restoring the user's personal information entered into web
 // forms. One per frame; owned by the AutofillDriver.
 class AutofillManager : public AutofillDownloadManager::Observer,
                         public CardUnmaskDelegate,
                         public payments::PaymentsClientDelegate {
  public:
   enum AutofillDownloadManagerState {
     ENABLE_AUTOFILL_DOWNLOAD_MANAGER,
     DISABLE_AUTOFILL_DOWNLOAD_MANAGER,
   };
 
   // Registers our Enable/Disable Autofill pref.
   static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
 
   AutofillManager(AutofillDriver* driver,
                   AutofillClient* client,
                   const std::string& app_locale,
                   AutofillDownloadManagerState enable_download_manager);
   ~AutofillManager() override;
 
   // Sets an external delegate.
   void SetExternalDelegate(AutofillExternalDelegate* delegate);
 
   void ShowAutofillSettings();
 
+  // Prompts the user for the CVC, uses the CVC to unmask the
+  // |maybe_masked_card| (if it's masked), and invokes |callback| with the
+  // unmasked card and the CVC. Only one unmask request should be active at a
+  // time. If there's already a pending unmask request, this |callback| is
+  // invoked immediately to indicate failure to the caller.
+  void UnmaskCardForPayment(const CreditCard& maybe_masked_card,
+                            const UnmaskCallback& callback);
+
   // Whether the |field| should show an entry to scan a credit card.
   virtual bool ShouldShowScanCreditCard(const FormData& form,
                                         const FormFieldData& field);
 
   // Called from our external delegate so they cannot be private.
   virtual void FillOrPreviewForm(AutofillDriver::RendererFormDataAction action,
                                  int query_id,
                                  const FormData& form,
                                  const FormFieldData& field,
                                  int unique_id);
@@ skipping 172 matching lines @@
   // payments::PaymentsClientDelegate:
   IdentityProvider* GetIdentityProvider() override;
   void OnDidGetRealPan(AutofillClient::PaymentsRpcResult result,
                        const std::string& real_pan) override;
   void OnDidGetUploadDetails(
       AutofillClient::PaymentsRpcResult result,
       const base::string16& context_token,
       std::unique_ptr<base::DictionaryValue> legal_message) override;
   void OnDidUploadCard(AutofillClient::PaymentsRpcResult result) override;
 
+  // UnmaskCallback:

[Mathieu, 2016/04/19 13:24:25]

Mention here or elsewhere why you are not using the cvc

+  void OnCardUnmasked(bool success,
+                      const CreditCard& original_card,
+                      const CreditCard& unmasked_card,
+                      const base::string16& unused_cvc);
+
   // Saves risk data in |unmasking_risk_data_| and calls UnmaskCard if the user
   // has accepted the prompt.
   void OnDidGetUnmaskRiskData(const std::string& risk_data);
 
   // Sets |user_did_accept_upload_prompt_| and calls UploadCard if the risk data
   // is available.
   void OnUserDidAcceptUpload();
 
   // Saves risk data in |uploading_risk_data_| and calls UploadCard if the user
   // has accepted the prompt.
@@ skipping 196 matching lines @@
   base::TimeTicks initial_interaction_timestamp_;
 
   // Our copy of the form data.
   ScopedVector<FormStructure> form_structures_;
 
   // A copy of the currently interacted form data.
   std::unique_ptr<FormData> pending_form_data_;
 
   // Collected information about a pending unmask request, and data about the
   // form.
+  std::unique_ptr<UnmaskCallback> unmask_callback_;
   payments::PaymentsClient::UnmaskRequestDetails unmask_request_;
   int unmasking_query_id_;
   FormData unmasking_form_;
   FormFieldData unmasking_field_;
   // Time when we requested the last real pan.
   base::Time real_pan_request_timestamp_;
 
   // Collected information about a pending upload request.
   payments::PaymentsClient::UploadRequestDetails upload_request_;
   bool user_did_accept_upload_prompt_;
@@ skipping 77 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
                            DontSaveCvcInAutocompleteHistory);
   FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DontOfferToSavePaymentsCard);
   FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, FillInUpdatedExpirationDate);
   DISALLOW_COPY_AND_ASSIGN(AutofillManager);
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_