Make Response::body return v8-extra based stream behind flag

third_party/WebKit/Source/modules/fetch/Request.cpp

Index: third_party/WebKit/Source/modules/fetch/Request.cpp
diff --git a/third_party/WebKit/Source/modules/fetch/Request.cpp b/third_party/WebKit/Source/modules/fetch/Request.cpp
index 54ddc5f9c1b5540c19eafb54c963f94dc017bedd..160afac6c938fd5957b235a7efacb4111bb78f10 100644
--- a/third_party/WebKit/Source/modules/fetch/Request.cpp
+++ b/third_party/WebKit/Source/modules/fetch/Request.cpp
@@ -268,7 +268,7 @@ Request* Request::createRequestWithRequestOrString(ScriptState* scriptState, Req
     }
     // "Let |r| be a new Request object associated with |request| and a new
     // Headers object whose guard is "request"."
-    Request* r = Request::create(scriptState->getExecutionContext(), request);
+    Request* r = Request::create(scriptState, request);
     // Perform the following steps:
     // - "Let |headers| be a copy of |r|'s Headers object."
     // - "If |init|'s headers member is present, set |headers| to |init|'s
@@ -343,7 +343,7 @@ Request* Request::createRequestWithRequestOrString(ScriptState* scriptState, Req
         //   contains no header named `Content-Type`, append
         //   `Content-Type`/|Content-Type| to |r|'s Headers object. Rethrow any
         //   exception."
-        temporaryBody = new BodyStreamBuffer(init.body.release());
+        temporaryBody = new BodyStreamBuffer(scriptState, init.body.release());
         if (!init.contentType.isEmpty() && !r->getHeaders()->has(HTTPNames::Content_Type, exceptionState)) {
             r->getHeaders()->append(HTTPNames::Content_Type, init.contentType, exceptionState);
         }
@@ -363,9 +363,9 @@ Request* Request::createRequestWithRequestOrString(ScriptState* scriptState, Req
     // non-null, run these substeps:"
     if (inputRequest && inputRequest->bodyBuffer()) {
         // "Set |input|'s body to an empty byte stream."
-        inputRequest->m_request->setBuffer(new BodyStreamBuffer(createFetchDataConsumerHandleFromWebHandle(createDoneDataConsumerHandle())));
+        inputRequest->m_request->setBuffer(new BodyStreamBuffer(scriptState, createFetchDataConsumerHandleFromWebHandle(createDoneDataConsumerHandle())));
         // "Set |input|'s disturbed flag."
-        inputRequest->bodyBuffer()->stream()->setIsDisturbed();
+        inputRequest->bodyBuffer()->setDisturbed();
     }
 
     // "Return |r|."
@@ -402,31 +402,31 @@ Request* Request::create(ScriptState* scriptState, Request* input, const Diction
     return createRequestWithRequestOrString(scriptState, input, String(), requestInit, exceptionState);
 }
 
-Request* Request::create(ExecutionContext* context, FetchRequestData* request)
+Request* Request::create(ScriptState* scriptState, FetchRequestData* request)
 {
-    return new Request(context, request);
+    return new Request(scriptState, request);
 }
 
-Request::Request(ExecutionContext* context, FetchRequestData* request)
-    : Body(context)
-    , m_request(request)
-    , m_headers(Headers::create(m_request->headerList()))
+Request* Request::create(ScriptState* scriptState, const WebServiceWorkerRequest& webRequest)
 {
-    m_headers->setGuard(Headers::RequestGuard);
+    return new Request(scriptState, webRequest);
 }
 
-Request::Request(ExecutionContext* context, FetchRequestData* request, Headers* headers)
-    : Body(context) , m_request(request) , m_headers(headers) {}
+Request::Request(ScriptState* scriptState, FetchRequestData* request)
+    : Request(scriptState, request, Headers::create(request->headerList()))
+{
+    m_headers->setGuard(Headers::RequestGuard);
+}
 
-Request* Request::create(ExecutionContext* context, const WebServiceWorkerRequest& webRequest)
+Request::Request(ScriptState* scriptState, FetchRequestData* request, Headers* headers)
+    : Body(scriptState->getExecutionContext())
+    , m_request(request)
+    , m_headers(headers)
 {
-    return new Request(context, webRequest);
 }
 
-Request::Request(ExecutionContext* context, const WebServiceWorkerRequest& webRequest)
-    : Body(context)
-    , m_request(FetchRequestData::create(context, webRequest))
-    , m_headers(Headers::create(m_request->headerList()))
+Request::Request(ScriptState* scriptState, const WebServiceWorkerRequest& webRequest)
+    : Request(scriptState, FetchRequestData::create(scriptState, webRequest))
 {
     m_headers->setGuard(Headers::RequestGuard);

[tyoshino (SeeGerritForStatus), 2016/04/21 07:46:24]

this will be invoked again in Request(ScriptState, FetchRequestData*)?

move to the constructor at L421-?

[yhirano, 2016/04/21 08:14:22]

Done.

 }
@@ -592,23 +592,23 @@ String Request::integrity() const
     return m_request->integrity();
 }
 
-Request* Request::clone(ExceptionState& exceptionState)
+Request* Request::clone(ScriptState* scriptState, ExceptionState& exceptionState)
 {
     if (isBodyLocked() || bodyUsed()) {
         exceptionState.throwTypeError("Request body is already used");
         return nullptr;
     }
 
-    FetchRequestData* request = m_request->clone(getExecutionContext());
+    FetchRequestData* request = m_request->clone(scriptState);
     Headers* headers = Headers::create(request->headerList());
     headers->setGuard(m_headers->getGuard());
-    return new Request(getExecutionContext(), request, headers);
+    return new Request(scriptState, request, headers);
 }
 
-FetchRequestData* Request::passRequestData()
+FetchRequestData* Request::passRequestData(ScriptState* scriptState)
 {
     ASSERT(!bodyUsed());
-    return m_request->pass(getExecutionContext());
+    return m_request->pass(scriptState);
 }
 
 bool Request::hasBody() const