third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp - Issue 1899873006: Make Response::body return v8-extra based stream behind flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp

Issue 1899873006: Make Response::body return v8-extra based stream behind flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@notify-locked-released

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp ('k') | third_party/WebKit/Source/modules/fetch/Body.h » ('j') | third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp

diff --git a/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp b/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp

index cbb59011804eabdfb58ddf04afcacea16ea8ef2e..291b13edeb9b2b5c96f030dfed2021c4ff9373a4 100644

--- a/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp

+++ b/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp

@@ -427,7 +427,7 @@ TEST_F(CacheStorageTest, BatchOperationArguments)

WebServiceWorkerResponse webResponse;

webResponse.setURL(KURL(ParsedURLString, url));

- Response* response = Response::create(getExecutionContext(), webResponse);

+ Response* response = Response::create(getScriptState(), webResponse);

WebVector<WebServiceWorkerCache::BatchOperation> expectedDeleteOperations(size_t(1));

{

@@ -459,7 +459,7 @@ TEST_F(CacheStorageTest, BatchOperationArguments)

request = newRequestFromUrl(url);

ASSERT(request);

- ScriptPromise putResult = cache->put(getScriptState(), requestToRequestInfo(request), response->clone(exceptionState()), exceptionState());

+ ScriptPromise putResult = cache->put(getScriptState(), requestToRequestInfo(request), response->clone(getScriptState(), exceptionState()), exceptionState());

EXPECT_EQ("dispatchBatch", testCache->getAndClearLastErrorWebCacheMethodCalled());

EXPECT_EQ(kNotImplementedString, getRejectString(putResult));

@@ -625,7 +625,7 @@ TEST_F(CacheStorageTest, Add)

fetcher->setExpectedFetchUrl(&url);

Request* request = newRequestFromUrl(url);

- Response* response = Response::create(getExecutionContext(), FetchFormDataConsumerHandle::create(content), contentType, ResponseInit(), exceptionState());

+ Response* response = Response::create(getScriptState(), FetchFormDataConsumerHandle::create(content), contentType, ResponseInit(), exceptionState());

fetcher->setResponse(response);

WebVector<WebServiceWorkerCache::BatchOperation> expectedPutOperations(size_t(1));