Support for type inference of top-level function invocations.

Support for type inference of top-level function invocations.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/9ec591573ac687afce5e23b9b0a5924bfa5f9cf8

[Paul Berry, 2016-04-18 20:08:27]

lgtm assuming the issue below is addressed.

https://codereview.chromium.org/1899873003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/link.dart (right):

https://codereview.chromium.org/1899873003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/link.dart:709: for (UnlinkedExecutable executable
in _unlinkedUnit.executables) {
Is CompilationUnitElement.functions supposed to return all executables
(functions, getters, and setters), or just functions?  I thought it was just
functions.

Assuming I'm remembering right, we'll need an "if" test here to make sure we
only add top level functions to the list.

[scheglov, 2016-04-18 20:24:08]

Description was changed from

==========
Support for type inference of top-level function invocations.

R=paulberry@google.com
BUG=
==========

to

==========
Support for type inference of top-level function invocations.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/9ec591573ac687afce5e23b9b0a5924bfa5f9cf8
==========

[scheglov, 2016-04-18 20:24:10]

Committed patchset #1 (id:1) manually as
9ec591573ac687afce5e23b9b0a5924bfa5f9cf8 (presubmit successful).

[scheglov, 2016-04-18 20:24:34]

https://codereview.chromium.org/1899873003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/link.dart (right):

https://codereview.chromium.org/1899873003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/link.dart:709: for (UnlinkedExecutable executable
in _unlinkedUnit.executables) {
On 2016/04/18 20:08:27, Paul Berry wrote:
> Is CompilationUnitElement.functions supposed to return all executables
> (functions, getters, and setters), or just functions?  I thought it was just
> functions.
> 
> Assuming I'm remembering right, we'll need an "if" test here to make sure we
> only add top level functions to the list.

You're right.
Done.