Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 1899853003: Safely iterate over MediaStreamSource observers. (Closed)

Created:
4 years, 8 months ago by sof
Modified:
4 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

Safely iterate over MediaStreamSource observers. When changing the ready state of this object, the resultant dispatching of events by its observers may extend the observer set. Take a snapshot of the observers, so as to be able safely iterate over it across additions. R= BUG=602273 Review URL: https://codereview.chromium.org/1885053002 Cr-Commit-Position: refs/heads/master@{#387243} (cherry picked from commit bc3ebdc42cd0b29fd770213d02a99a81b84dc69c) Committed: https://chromium.googlesource.com/chromium/src/+/cc916de6955699b06e38ed659805c1fc3904126c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -5 lines) Patch
A third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-observer-iterate-no-crash.html View 1 chunk +41 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-observer-iterate-no-crash-expected.txt View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sof
4 years, 8 months ago (2016-04-18 18:54:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cc916de6955699b06e38ed659805c1fc3904126c.

Powered by Google App Engine
This is Rietveld 408576698