Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1899853002: Remove CRWWKWebViewWebController variables. (Closed)

Created:
4 years, 8 months ago by michaeldo
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CRWWKWebViewWebController variables. Move last two instance variables to CRWWebController. BUG=579697 Committed: https://crrev.com/1137d697c29caf3aae25342662a585f79309023d Cr-Commit-Position: refs/heads/master@{#388010}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -76 lines) Patch
M ios/web/web_state/ui/crw_web_controller.mm View 17 chunks +41 lines, -14 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller+protected.h View 2 chunks +0 lines, -21 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_web_view_web_controller.mm View 3 chunks +1 line, -41 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
michaeldo
4 years, 8 months ago (2016-04-18 18:45:08 UTC) #2
Eugene But (OOO till 7-30)
lgtm
4 years, 8 months ago (2016-04-18 18:57:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899853002/1
4 years, 8 months ago (2016-04-18 20:11:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-18 20:54:15 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 20:55:35 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1137d697c29caf3aae25342662a585f79309023d
Cr-Commit-Position: refs/heads/master@{#388010}

Powered by Google App Engine
This is Rietveld 408576698