Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 1899823002: Uses the activedescendant_changed event received from Blink to fire the right focus event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed extraneous focus events. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_win.cc
diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc
index 98aeb77bc7724b0f3474cdf03ef5a64d6a5a7df0..0ad9ba863437d48791af5f66a35ddbde356f46ef 100644
--- a/content/browser/accessibility/browser_accessibility_win.cc
+++ b/content/browser/accessibility/browser_accessibility_win.cc
@@ -3519,18 +3519,6 @@ void BrowserAccessibilityWin::UpdateStep3FireEvents(bool is_subtree_creation) {
if (ia_state() != old_win_attributes_->ia_state)
manager->MaybeCallNotifyWinEvent(EVENT_OBJECT_STATECHANGE, this);
- // Normally focus events are handled elsewhere, however
dmazzoni 2016/04/26 20:24:24 Are you sure this isn't needed anymore? Do both NV
- // focus for managed descendants is platform-specific.
- // Fire a focus event if the focused descendant in a multi-select
- // list box changes.
- if (GetRole() == ui::AX_ROLE_LIST_BOX_OPTION &&
- (ia_state() & STATE_SYSTEM_FOCUSABLE) &&
- (ia_state() & STATE_SYSTEM_SELECTABLE) &&
- (ia_state() & STATE_SYSTEM_FOCUSED) &&
- !(old_win_attributes_->ia_state & STATE_SYSTEM_FOCUSED)) {
- manager->MaybeCallNotifyWinEvent(EVENT_OBJECT_FOCUS, this);
- }
-
// Handle selection being added or removed.
bool is_selected_now = (ia_state() & STATE_SYSTEM_SELECTED) != 0;
bool was_selected_before =

Powered by Google App Engine
This is Rietveld 408576698