Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Unified Diff: content/browser/accessibility/browser_accessibility_manager_mac.mm

Issue 1899823002: Uses the activedescendant_changed event received from Blink to fire the right focus event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed extraneous focus events. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_manager_mac.mm
diff --git a/content/browser/accessibility/browser_accessibility_manager_mac.mm b/content/browser/accessibility/browser_accessibility_manager_mac.mm
index e43122e120b781bb679f08817e1d4323d9e8b73a..337ac2530773f74a95da6118a8a6a3ae6e650008 100644
--- a/content/browser/accessibility/browser_accessibility_manager_mac.mm
+++ b/content/browser/accessibility/browser_accessibility_manager_mac.mm
@@ -145,20 +145,6 @@ void BrowserAccessibilityManagerMac::NotifyAccessibilityEvent(
if (!node->IsNative())
return;
- if (event_type == ui::AX_EVENT_FOCUS) {
- BrowserAccessibility* active_descendant = GetActiveDescendantFocus(node);
- if (active_descendant)
- node = active_descendant;
-
- if (node->GetRole() == ui::AX_ROLE_LIST_BOX_OPTION &&
- node->HasState(ui::AX_STATE_SELECTED) &&
- node->GetParent() &&
- node->GetParent()->GetRole() == ui::AX_ROLE_LIST_BOX) {
- node = node->GetParent();
- SetFocus(*node);
- }
- }
-
auto native_node = ToBrowserAccessibilityCocoa(node);
DCHECK(native_node);
@@ -175,6 +161,10 @@ void BrowserAccessibilityManagerMac::NotifyAccessibilityEvent(
mac_notification = NSAccessibilitySelectedChildrenChangedNotification;
} else {
mac_notification = NSAccessibilityFocusedUIElementChangedNotification;
+ BrowserAccessibility* focus = GetFocus();
+ if (!focus)
+ return;
+ native_node = ToBrowserAccessibilityCocoa(focus);
dmazzoni 2016/04/26 20:24:24 I wonder, is this maybe not necessary now? After
}
break;
case ui::AX_EVENT_AUTOCORRECTION_OCCURED:

Powered by Google App Engine
This is Rietveld 408576698