content/browser/accessibility/browser_accessibility_win.cc - Issue 1899823002: Uses the activedescendant_changed event received from Blink to fire the right focus event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win.cc

Issue 1899823002: Uses the activedescendant_changed event received from Blink to fire the right focus event (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed menu-list-open Layout test. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_manager_win.cc ('k') | content/browser/accessibility/dump_accessibility_events_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_win.cc

diff --git a/content/browser/accessibility/browser_accessibility_win.cc b/content/browser/accessibility/browser_accessibility_win.cc

index 76060e0aea5844a84f4339c729524cb365abf298..816aa2bf3ff8f229fc121d7438d08909061a22cb 100644

--- a/content/browser/accessibility/browser_accessibility_win.cc

+++ b/content/browser/accessibility/browser_accessibility_win.cc

@@ -3604,18 +3604,6 @@ void BrowserAccessibilityWin::UpdateStep3FireEvents(bool is_subtree_creation) {

if (ia_state() != old_win_attributes_->ia_state)

FireNativeEvent(EVENT_OBJECT_STATECHANGE);

- // Normally focus events are handled elsewhere, however

- // focus for managed descendants is platform-specific.

- // Fire a focus event if the focused descendant in a multi-select

- // list box changes.

- if (GetRole() == ui::AX_ROLE_LIST_BOX_OPTION &&

- (ia_state() & STATE_SYSTEM_FOCUSABLE) &&

- (ia_state() & STATE_SYSTEM_SELECTABLE) &&

- (ia_state() & STATE_SYSTEM_FOCUSED) &&

- !(old_win_attributes_->ia_state & STATE_SYSTEM_FOCUSED)) {

- FireNativeEvent(EVENT_OBJECT_FOCUS);

- }

// Handle selection being added or removed.

bool is_selected_now = (ia_state() & STATE_SYSTEM_SELECTED) != 0;

bool was_selected_before =