src/profiler/sampling-heap-profiler.cc - Issue 1899813003: [crankshaft] Fragmentation-free allocation folding.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/profiler/sampling-heap-profiler.cc

Issue 1899813003: [crankshaft] Fragmentation-free allocation folding. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/profiler/sampling-heap-profiler.cc

diff --git a/src/profiler/sampling-heap-profiler.cc b/src/profiler/sampling-heap-profiler.cc

index 16798a654b80dc07194ade88391227ad4dea836b..62fd48b5a77530eeb5557315e4c09fc0c5f1ba7d 100644

--- a/src/profiler/sampling-heap-profiler.cc

+++ b/src/profiler/sampling-heap-profiler.cc

@@ -111,7 +111,6 @@ void SamplingHeapProfiler::SampleObject(Address soon_object, size_t size) {

Sample* sample = new Sample(size, node, loc, this);

samples_.insert(sample);

sample->global.SetWeak(sample, OnWeakCallback, WeakCallbackType::kParameter);

Michael Lippautz 2016/05/10 08:32:58 Left over? Rebase needed?

Hannes Payer (out of office) 2016/05/10 09:04:45 Strange. Done.

- sample->global.MarkIndependent();

}

void SamplingHeapProfiler::OnWeakCallback(