chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc - Issue 1899803002: Offline Pages: Use 'binary encoding' to create MHTML, instead of base64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

Issue 1899803002: Offline Pages: Use 'binary encoding' to create MHTML, instead of base64. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use HasSubstr instead of ContainsRegex when appropriate. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/native/aw_contents.cc ('k') | chrome/browser/extensions/api/page_capture/page_capture_api.cc » ('j') | content/browser/download/mhtml_generation_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

index 2087eb84f3b8d274e07edaab8641200932c1da2a..abb8bf58da16f4a82aaf38e1f02ea84634313c9d 100644

--- a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

+++ b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

@@ -111,8 +111,9 @@ void OfflinePageMHTMLArchiver::GenerateMHTML(

GenerateFileName(url, base::UTF16ToUTF8(title), archive_id)));

web_contents_->GenerateMHTML(

- file_path, base::Bind(&OfflinePageMHTMLArchiver::OnGenerateMHTMLDone,

- weak_ptr_factory_.GetWeakPtr(), url, file_path));

+ file_path, /* use_binary_encoding= */ true,

+ base::Bind(&OfflinePageMHTMLArchiver::OnGenerateMHTMLDone,

+ weak_ptr_factory_.GetWeakPtr(), url, file_path));

}

void OfflinePageMHTMLArchiver::OnGenerateMHTMLDone(