content/renderer/render_frame_impl.cc - Issue 1899803002: Offline Pages: Use 'binary encoding' to create MHTML, instead of base64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1899803002: Offline Pages: Use 'binary encoding' to create MHTML, instead of base64. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Final nits. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_frame_impl.cc

diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc

index 5fadcf6837e27d97df027ba2cdd3a5ca5f575121..97b26b1272143806d65645897dac29bf7f18ed07 100644

--- a/content/renderer/render_frame_impl.cc

+++ b/content/renderer/render_frame_impl.cc

@@ -4925,8 +4925,8 @@ void RenderFrameImpl::OnSerializeAsMHTML(

// Generate MHTML parts.

if (success) {

- data = WebFrameSerializer::generateMHTMLParts(mhtml_boundary, GetWebFrame(),

- false, &delegate);

+ data = WebFrameSerializer::generateMHTMLParts(

+ mhtml_boundary, GetWebFrame(), params.mhtml_binary_encoding, &delegate);

// TODO(jcivelli): write the chunks in deferred tasks to give a chance to

// the message loop to process other events.

if (file.WriteAtCurrentPos(data.data(), data.size()) < 0) {

« no previous file with comments | « content/public/browser/web_contents.h ('k') | content/test/data/blank.jpg » ('j') | no next file with comments »