Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: content/browser/download/mhtml_generation_manager.h

Issue 1899803002: Offline Pages: Use 'binary encoding' to create MHTML, instead of base64. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Final nits. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/mhtml_generation_manager.h
diff --git a/content/browser/download/mhtml_generation_manager.h b/content/browser/download/mhtml_generation_manager.h
index 24e729a86d719dac2342e044ebcc8a0fa5559cd0..8a76f4f421c9136e1a4482b75bcc9d40aaed4b64 100644
--- a/content/browser/download/mhtml_generation_manager.h
+++ b/content/browser/download/mhtml_generation_manager.h
@@ -40,6 +40,7 @@ class MHTMLGenerationManager {
// Instructs the render view to generate a MHTML representation of the current
// page for |web_contents|.
void SaveMHTML(WebContents* web_contents,
+ bool use_binary_encoding,
const base::FilePath& file_path,
const GenerateMHTMLCallback& callback);
@@ -73,7 +74,9 @@ class MHTMLGenerationManager {
void OnFileClosed(int job_id, JobStatus job_status, int64_t file_size);
// Creates and registers a new job.
- int NewJob(WebContents* web_contents, const GenerateMHTMLCallback& callback);
+ int NewJob(WebContents* web_contents,
+ bool use_binary_encoding,
+ const GenerateMHTMLCallback& callback);
// Finds job by id. Returns nullptr if no job with a given id was found.
Job* FindJob(int job_id);
« no previous file with comments | « content/browser/download/mhtml_generation_browsertest.cc ('k') | content/browser/download/mhtml_generation_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698