Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc

Issue 1899803002: Offline Pages: Use 'binary encoding' to create MHTML, instead of base64. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Final nits. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc
index 2087eb84f3b8d274e07edaab8641200932c1da2a..b2a0372dc964648c26e94e716724eed7fd7590ad 100644
--- a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc
+++ b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc
@@ -111,8 +111,9 @@ void OfflinePageMHTMLArchiver::GenerateMHTML(
GenerateFileName(url, base::UTF16ToUTF8(title), archive_id)));
web_contents_->GenerateMHTML(
- file_path, base::Bind(&OfflinePageMHTMLArchiver::OnGenerateMHTMLDone,
- weak_ptr_factory_.GetWeakPtr(), url, file_path));
+ file_path, true /* use_binary_encoding */,
+ base::Bind(&OfflinePageMHTMLArchiver::OnGenerateMHTMLDone,
+ weak_ptr_factory_.GetWeakPtr(), url, file_path));
}
void OfflinePageMHTMLArchiver::OnGenerateMHTMLDone(
« no previous file with comments | « android_webview/native/aw_contents.cc ('k') | chrome/browser/extensions/api/page_capture/page_capture_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698