Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2108)

Unified Diff: content/public/browser/web_contents.h

Issue 1899803002: Offline Pages: Use 'binary encoding' to create MHTML, instead of base64. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address nasko's comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents.h
diff --git a/content/public/browser/web_contents.h b/content/public/browser/web_contents.h
index eb0da0053015e6628ce668f844482e4f5700d8b4..fd6e05070d6e0401f7a6b18de15c8e9c402236d9 100644
--- a/content/public/browser/web_contents.h
+++ b/content/public/browser/web_contents.h
@@ -540,8 +540,13 @@ class WebContents : public PageNavigator,
const std::string& headers) = 0;
// Generate an MHTML representation of the current page in the given file.
+ // If |use_binary_encoding| is specified, a Content-Transfer-Encoding value of
+ // 'binary' will be used, instead of a combination of 'quoted-printable' and
+ // 'base64'. Binary encoding is known to have interoperability issues and so
nasko 2016/04/20 22:22:38 nit: s/so//
+ // is not the recommended encoding for shareable content.
virtual void GenerateMHTML(
const base::FilePath& file,
+ bool use_binary_encoding,
const base::Callback<void(int64_t /* size of the file */)>& callback) = 0;
// Returns the contents MIME type after a navigation.

Powered by Google App Engine
This is Rietveld 408576698