content/browser/web_contents/web_contents_impl.cc - Issue 1899803002: Offline Pages: Use 'binary encoding' to create MHTML, instead of base64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1899803002: Offline Pages: Use 'binary encoding' to create MHTML, instead of base64. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address nasko's comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/mhtml_generation_browsertest.cc ('K') | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/frame_messages.h » ('j') | content/public/browser/web_contents.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index b88c94f96e797276d72e9cd9d1e9f67c6f1e21fa..d7b45b73ae2f5482699c71789130a2af9257f74d 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -2749,8 +2749,10 @@ void WebContentsImpl::SaveFrameWithHeaders(const GURL& url,

void WebContentsImpl::GenerateMHTML(

const base::FilePath& file,

+ bool use_binary_encoding,

const base::Callback<void(int64_t)>& callback) {

- MHTMLGenerationManager::GetInstance()->SaveMHTML(this, file, callback);

+ MHTMLGenerationManager::GetInstance()->SaveMHTML(this, use_binary_encoding,

+ file, callback);

}

const std::string& WebContentsImpl::GetContentsMimeType() const {