Offline Pages: Use 'binary encoding' to create MHTML, instead of base64.

content/browser/download/save_package.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/save_package.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 320 matching lines @@
   // Confirm above didn't delete the tab out from under us.
   if (!download_created_callback.is_null())
     download_created_callback.Run(download_);
 
   // Check save type and process the save page job.
   if (save_type_ == SAVE_PAGE_TYPE_AS_COMPLETE_HTML) {
     // Get directory
     DCHECK(!saved_main_directory_path_.empty());
     GetSavableResourceLinks();
   } else if (save_type_ == SAVE_PAGE_TYPE_AS_MHTML) {
-    web_contents()->GenerateMHTML(saved_main_file_path_, base::Bind(
-        &SavePackage::OnMHTMLGenerated, this));
+    web_contents()->GenerateMHTML(
+        saved_main_file_path_, /* use_binary_encoding = */ false,

[nasko, 2016/04/20 17:01:15]

nit: Comment for the name of parameter should go after the value.

[dewittj, 2016/04/20 20:20:59]

I will make the change, but there isn't anywhere in the style guide that
suggests this, in fact the only example has preceding (see Function Argument
Comments).

[nasko, 2016/04/20 22:22:38]

I'm going with consistency across code in content/, especially prevalent in IPC
message files. Example:
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/fr...

+        base::Bind(&SavePackage::OnMHTMLGenerated, this));
   } else {
     DCHECK_EQ(SAVE_PAGE_TYPE_AS_ONLY_HTML, save_type_);
     wait_state_ = NET_FILES;
     SaveFileCreateInfo::SaveFileSource save_source = page_url_.SchemeIsFile() ?
         SaveFileCreateInfo::SAVE_FILE_FROM_FILE :
         SaveFileCreateInfo::SAVE_FILE_FROM_NET;
     // Add this item to waiting list.
     waiting_item_queue_.push_back(
         new SaveItem(page_url_, Referrer(), this, save_source,
                      FrameTreeNode::kFrameTreeNodeInvalidId));
@@ skipping 1140 matching lines @@
 }
 
 void SavePackage::FinalizeDownloadEntry() {
   DCHECK(download_);
 
   download_manager_->OnSavePackageSuccessfullyFinished(download_);
   StopObservation();
 }
 
 }  // namespace content