Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1899803002: Offline Pages: Use 'binary encoding' to create MHTML, instead of base64. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Final nits. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/frame_messages.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 #include <utility> 10 #include <utility>
(...skipping 2731 matching lines...) Expand 10 before | Expand all | Expand 10 after
2742 key_value, ":", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL); 2742 key_value, ":", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
2743 DCHECK_EQ(2ul, pair.size()); 2743 DCHECK_EQ(2ul, pair.size());
2744 params->add_request_header(pair[0], pair[1]); 2744 params->add_request_header(pair[0], pair[1]);
2745 } 2745 }
2746 } 2746 }
2747 dlm->DownloadUrl(std::move(params)); 2747 dlm->DownloadUrl(std::move(params));
2748 } 2748 }
2749 2749
2750 void WebContentsImpl::GenerateMHTML( 2750 void WebContentsImpl::GenerateMHTML(
2751 const base::FilePath& file, 2751 const base::FilePath& file,
2752 bool use_binary_encoding,
2752 const base::Callback<void(int64_t)>& callback) { 2753 const base::Callback<void(int64_t)>& callback) {
2753 MHTMLGenerationManager::GetInstance()->SaveMHTML(this, file, callback); 2754 MHTMLGenerationManager::GetInstance()->SaveMHTML(this, use_binary_encoding,
2755 file, callback);
2754 } 2756 }
2755 2757
2756 const std::string& WebContentsImpl::GetContentsMimeType() const { 2758 const std::string& WebContentsImpl::GetContentsMimeType() const {
2757 return contents_mime_type_; 2759 return contents_mime_type_;
2758 } 2760 }
2759 2761
2760 bool WebContentsImpl::WillNotifyDisconnection() const { 2762 bool WebContentsImpl::WillNotifyDisconnection() const {
2761 return notify_disconnection_; 2763 return notify_disconnection_;
2762 } 2764 }
2763 2765
(...skipping 2193 matching lines...) Expand 10 before | Expand all | Expand 10 after
4957 for (RenderViewHost* render_view_host : render_view_host_set) 4959 for (RenderViewHost* render_view_host : render_view_host_set)
4958 render_view_host->OnWebkitPreferencesChanged(); 4960 render_view_host->OnWebkitPreferencesChanged();
4959 } 4961 }
4960 4962
4961 void WebContentsImpl::SetJavaScriptDialogManagerForTesting( 4963 void WebContentsImpl::SetJavaScriptDialogManagerForTesting(
4962 JavaScriptDialogManager* dialog_manager) { 4964 JavaScriptDialogManager* dialog_manager) {
4963 dialog_manager_ = dialog_manager; 4965 dialog_manager_ = dialog_manager;
4964 } 4966 }
4965 4967
4966 } // namespace content 4968 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/common/frame_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698