Issue 18998003: Revert "Calls to HCheckFunction can be eliminated if the value is an HConstant"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18998003: Revert "Calls to HCheckFunction can be eliminated if the value is an HConstant" (Closed)

Created:
7 years, 5 months ago by mvstanton

Modified:
7 years, 5 months ago

Reviewers:
danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "Calls to HCheckFunction can be eliminated if the value is an HConstant" This reverts commit 3f96122cc572f7a0b638c30f65328c3cb3666795. BUG= R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15590

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -17 lines)			Patch
M	src/hydrogen-instructions.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

mvstanton

Hi Danno, this CL breaks the Webkit heap snapshot tests, by exposing an array without ...

7 years, 5 months ago (2013-07-10 12:12:59 UTC) #1

mvstanton

7 years, 5 months ago (2013-07-10 12:19:43 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15590 (presubmit successful).