Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1899763002: PPC: Correctly annotate eval origin. (Closed)

Created:
4 years, 8 months ago by JaideepBajwa
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Correctly annotate eval origin. Port 89d7bfda0d3d3ed48a174a2851cfe5da0b31f056 Original commit message: There were a couple of issues with it: - interpreter is not supported - the source position was just accidentally correct for full-codegen - the eval origin could have been cached Also fixes a few other places to use AbstractCode. R=yangguo@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com, jyan@ca.ibm.com BUG= Committed: https://crrev.com/306add32e5c321145002015c1bf830f511d13534 Cr-Commit-Position: refs/heads/master@{#35587}

Patch Set 1 #

Patch Set 2 : Minor fix, added a missing declaration of arg_count #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
JaideepBajwa
PTAL
4 years, 8 months ago (2016-04-18 14:49:15 UTC) #1
MTBrandyberry
lgtm
4 years, 8 months ago (2016-04-18 15:06:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899763002/20001
4 years, 8 months ago (2016-04-18 15:07:07 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-18 15:24:47 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 15:25:13 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/306add32e5c321145002015c1bf830f511d13534
Cr-Commit-Position: refs/heads/master@{#35587}

Powered by Google App Engine
This is Rietveld 408576698