[wasm] Wasm functions with int64 parameters can now be called from JS.

[wasm] Wasm functions with int64 parameters can now be called from JS.

All wasm spec tests can now be run on ia32.

R=titzer@chromium.org

Committed: https://crrev.com/965e6bdc0a587ff5b8a04f7377af23fc76aeef38
Cr-Commit-Position: refs/heads/master@{#35663}

[titzer, 2016-04-19 14:59:28]

On 2016/04/19 14:21:10, ahaas wrote:

You should add some test/mjsunit/wasm tests for this behavior.

[ahaas, 2016-04-20 13:52:03]

On 2016/04/19 at 14:59:28, titzer wrote:
> On 2016/04/19 14:21:10, ahaas wrote:
> 
> You should add some test/mjsunit/wasm tests for this behavior.

Done.

[titzer, 2016-04-20 13:58:21]

lgtm

https://codereview.chromium.org/1899753004/diff/20001/src/compiler/int64-lowe...
File src/compiler/int64-lowering.cc (right):

https://codereview.chromium.org/1899753004/diff/20001/src/compiler/int64-lowe...
src/compiler/int64-lowering.cc:84: return GetParameterIndexAfterLowering(
Does this work if the last parameter is an int64? Not clear.

[ahaas, 2016-04-20 14:16:39]

https://codereview.chromium.org/1899753004/diff/20001/src/compiler/int64-lowe...
File src/compiler/int64-lowering.cc (right):

https://codereview.chromium.org/1899753004/diff/20001/src/compiler/int64-lowe...
src/compiler/int64-lowering.cc:84: return GetParameterIndexAfterLowering(
On 2016/04/20 at 13:58:21, titzer wrote:
> Does this work if the last parameter is an int64? Not clear.

I added a comment.

[ahaas, 2016-04-20 14:16:45]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-04-20 14:16:45]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1899753004/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-04-20 14:16:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899753004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899753004/40001

[ahaas, 2016-04-20 14:19:44]

The CQ bit was unchecked by ahaas@chromium.org

[ahaas, 2016-04-20 14:21:54]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-04-20 14:21:54]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1899753004/#ps60001
(title: " ")

[commit-bot: I haz the power, 2016-04-20 14:21:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899753004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899753004/60001

[commit-bot: I haz the power, 2016-04-20 14:44:22]

Committed patchset #4 (id:60001)

[nodir1, 2016-04-22 18:44:20]

Description was changed from

==========
[wasm] Wasm functions with int64 parameters can now be called from JS.

All wasm spec tests can now be run on ia32.

R=titzer@chromium.org
==========

to

==========
[wasm] Wasm functions with int64 parameters can now be called from JS.

All wasm spec tests can now be run on ia32.

R=titzer@chromium.org

Committed: https://crrev.com/965e6bdc0a587ff5b8a04f7377af23fc76aeef38
Cr-Commit-Position: refs/heads/master@{#35663}
==========

[nodir1, 2016-04-22 18:44:21]

Patchset 4 (id:??) landed as
https://crrev.com/965e6bdc0a587ff5b8a04f7377af23fc76aeef38
Cr-Commit-Position: refs/heads/master@{#35663}