net/tools/quic/test_tools/mock_quic_time_wait_list_manager.cc - Issue 1899753003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/test_tools/mock_quic_time_wait_list_manager.cc

Issue 1899753003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679

Patch Set: Fixing up unique pointers Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/tools/quic/test_tools/mock_quic_time_wait_list_manager.h ('k') | net/tools/quic/test_tools/packet_dropping_test_writer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/tools/quic/test_tools/mock_quic_time_wait_list_manager.cc

diff --git a/net/tools/quic/test_tools/mock_quic_time_wait_list_manager.cc b/net/tools/quic/test_tools/mock_quic_time_wait_list_manager.cc

index 468e6efded71818b3427f7b96dc582f6e59e01c6..54b780507fab4d2a861c8d9dd43df3413d1b4e14 100644

--- a/net/tools/quic/test_tools/mock_quic_time_wait_list_manager.cc

+++ b/net/tools/quic/test_tools/mock_quic_time_wait_list_manager.cc

@@ -14,8 +14,9 @@ namespace test {

MockTimeWaitListManager::MockTimeWaitListManager(

QuicPacketWriter* writer,

QuicServerSessionVisitor* visitor,

- QuicConnectionHelperInterface* helper)

- : QuicTimeWaitListManager(writer, visitor, helper) {

+ QuicConnectionHelperInterface* helper,

+ QuicAlarmFactory* alarm_factory)

+ : QuicTimeWaitListManager(writer, visitor, helper, alarm_factory) {

// Though AddConnectionIdToTimeWait is mocked, we want to retain its

// functionality.

EXPECT_CALL(*this, AddConnectionIdToTimeWait(_, _, _, _))