net/tools/quic/quic_simple_server_stream_test.cc - Issue 1899753003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_simple_server_stream_test.cc

Issue 1899753003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679

Patch Set: Fixing up unique pointers Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/quic_simple_server_stream_test.cc

diff --git a/net/tools/quic/quic_simple_server_stream_test.cc b/net/tools/quic/quic_simple_server_stream_test.cc

index 2914defbf15f27791dfcfd335f4af5bc6eeb0fd9..f23c6ee79b2ba2af921c46ad9b8b88f10125fbcb 100644

--- a/net/tools/quic/quic_simple_server_stream_test.cc

+++ b/net/tools/quic/quic_simple_server_stream_test.cc

@@ -150,6 +150,7 @@ class QuicSimpleServerStreamTest

QuicSimpleServerStreamTest()

: connection_(

new StrictMock<MockConnection>(&helper_,

+ &alarm_factory_,

Perspective::IS_SERVER,

SupportedVersions(GetParam()))),

session_owner_(new StrictMock<MockQuicServerSessionVisitor>()),

@@ -204,6 +205,7 @@ class QuicSimpleServerStreamTest

SpdyHeaderBlock response_headers_;

MockConnectionHelper helper_;

+ MockAlarmFactory alarm_factory_;

StrictMock<MockConnection>* connection_;

StrictMock<MockQuicServerSessionVisitor>* session_owner_;

std::unique_ptr<QuicCryptoServerConfig> crypto_config_;

« no previous file with comments | « net/tools/quic/quic_simple_server_session_test.cc ('k') | net/tools/quic/quic_simple_server_test.cc » ('j') | no next file with comments »