net/tools/quic/quic_client_base.cc - Issue 1899753003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_client_base.cc

Issue 1899753003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679

Patch Set: Fixing up unique pointers Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/quic_client_base.cc

diff --git a/net/tools/quic/quic_client_base.cc b/net/tools/quic/quic_client_base.cc

index 91000db2c14f2271f7c44d7f19302f617c6cf319..211c54d8e9802db9dd82ec42a8bf35d8e4bb97d9 100644

--- a/net/tools/quic/quic_client_base.cc

+++ b/net/tools/quic/quic_client_base.cc

@@ -13,11 +13,13 @@ QuicClientBase::QuicClientBase(const QuicServerId& server_id,

const QuicVersionVector& supported_versions,

const QuicConfig& config,

QuicConnectionHelperInterface* helper,

+ QuicAlarmFactory* alarm_factory,

ProofVerifier* proof_verifier)

: server_id_(server_id),

config_(config),

crypto_config_(proof_verifier),

helper_(helper),

+ alarm_factory_(alarm_factory),

supported_versions_(supported_versions),

initial_max_packet_length_(0),

num_stateless_rejects_received_(0),

« no previous file with comments | « net/tools/quic/quic_client_base.h ('k') | net/tools/quic/quic_client_session_test.cc » ('j') | no next file with comments »