net/quic/test_tools/crypto_test_utils.h - Issue 1899753003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/test_tools/crypto_test_utils.h

Issue 1899753003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679

Patch Set: Fixing up unique pointers Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/test_tools/crypto_test_utils.h

diff --git a/net/quic/test_tools/crypto_test_utils.h b/net/quic/test_tools/crypto_test_utils.h

index 6d2ad006954f7f49e782deff2a071b5493416edb..c8beb6092a78c17d18d3328e11ecfb70cfd33879 100644

--- a/net/quic/test_tools/crypto_test_utils.h

+++ b/net/quic/test_tools/crypto_test_utils.h

@@ -86,12 +86,16 @@ class CryptoTestUtils {

// returns: the number of client hellos that the client sent.

static int HandshakeWithFakeServer(MockConnectionHelper* helper,

+ MockAlarmFactory* alarm_factory,

PacketSavingConnection* client_conn,

QuicCryptoClientStream* client,

const FakeServerOptions& options);

// returns: the number of client hellos that the client sent.

static int HandshakeWithFakeClient(MockConnectionHelper* helper,

+ MockAlarmFactory* alarm_factory,

PacketSavingConnection* server_conn,

QuicCryptoServerStream* server,

const QuicServerId& server_id,

« no previous file with comments | « net/quic/reliable_quic_stream_test.cc ('k') | net/quic/test_tools/crypto_test_utils.cc » ('j') | no next file with comments »