net/quic/quic_chromium_client_stream_test.cc - Issue 1899753003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_chromium_client_stream_test.cc

Issue 1899753003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679

Patch Set: Fixing up unique pointers Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_chromium_client_stream_test.cc

diff --git a/net/quic/quic_chromium_client_stream_test.cc b/net/quic/quic_chromium_client_stream_test.cc

index 4b1d31ed608b2de0be80374bf19bfb2756bb4d81..b7c888c1bba848cba5ead83a372bfc56fbb35076 100644

--- a/net/quic/quic_chromium_client_stream_test.cc

+++ b/net/quic/quic_chromium_client_stream_test.cc

@@ -144,6 +144,7 @@ class QuicChromiumClientStreamTest

QuicChromiumClientStreamTest()

: crypto_config_(CryptoTestUtils::ProofVerifierForTesting()),

session_(new MockConnection(&helper_,

+ &alarm_factory_,

Perspective::IS_CLIENT,

SupportedVersions(GetParam())),

&push_promise_index_) {

@@ -194,6 +195,7 @@ class QuicChromiumClientStreamTest

QuicCryptoClientConfig crypto_config_;

testing::StrictMock<MockDelegate> delegate_;

MockConnectionHelper helper_;

+ MockAlarmFactory alarm_factory_;

MockQuicClientSessionBase session_;

QuicChromiumClientStream* stream_;

SpdyHeaderBlock headers_;

« no previous file with comments | « net/quic/quic_chromium_client_session_test.cc ('k') | net/quic/quic_chromium_connection_helper.h » ('j') | no next file with comments »