net/BUILD.gn - Issue 1899753003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/BUILD.gn

Issue 1899753003: Split out QuicAlarm creation from QuicConnectionHelper to new QuicAlarmFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@119871679

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/BUILD.gn

diff --git a/net/BUILD.gn b/net/BUILD.gn

index 48cbb81d65a6fb5e58dbbf120c8f21c38c8832b3..06b10e387c78376a5644c97272ebd9726815ea33 100644

--- a/net/BUILD.gn

+++ b/net/BUILD.gn

@@ -1209,6 +1209,8 @@ if (is_linux) {

"tools/quic/quic_default_packet_writer.h",

"tools/quic/quic_epoll_clock.cc",

"tools/quic/quic_epoll_clock.h",

+ "tools/quic/quic_epoll_connection_alarm_factory.cc",

+ "tools/quic/quic_epoll_connection_alarm_factory.h",

Ryan Hamilton 2016/04/18 22:10:54 I don't think we need "Connection" in the name. qu

"tools/quic/quic_epoll_connection_helper.cc",

"tools/quic/quic_epoll_connection_helper.h",

"tools/quic/quic_packet_reader.cc",

« no previous file with comments | « no previous file | net/net.gyp » ('j') | net/quic/quic_alarm_factory.h » ('J')