components/gcm_driver/instance_id/instance_id_impl.cc - Issue 1899753002: Make InstanceIDBridge fully async to fix strict mode violations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/instance_id/instance_id_impl.cc

Issue 1899753002: Make InstanceIDBridge fully async to fix strict mode violations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid3test

Patch Set: Fix DeleteID use after free Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/gcm_driver/instance_id/instance_id_impl.cc

diff --git a/components/gcm_driver/instance_id/instance_id_impl.cc b/components/gcm_driver/instance_id/instance_id_impl.cc

index f7e50141c0cfeeea07d5cff11240f0bef54d72e0..85070b284c30bd8fe4a65d1832e0006eb2dcc274 100644

--- a/components/gcm_driver/instance_id/instance_id_impl.cc

+++ b/components/gcm_driver/instance_id/instance_id_impl.cc

@@ -211,6 +211,7 @@ void InstanceIDImpl::OnDeleteIDCompleted(

const DeleteIDCallback& callback,

gcm::GCMClient::Result result) {

callback.Run(GCMClientResultToInstanceIDResult(result));

+ // Now |this| will likely have been deleted.

}

void InstanceIDImpl::GetInstanceIDDataCompleted(

« components/gcm_driver/instance_id/instance_id_android.cc ('K') | « components/gcm_driver/instance_id/instance_id_android.cc ('k') | no next file » | no next file with comments »