Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: components/gcm_driver/instance_id/instance_id.h

Issue 1899753002: Make InstanceIDBridge fully async to fix strict mode violations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid3test
Patch Set: |this| Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/instance_id/instance_id.h
diff --git a/components/gcm_driver/instance_id/instance_id.h b/components/gcm_driver/instance_id/instance_id.h
index 3aa7658e9a3738c20df0b43c148a780dcadb877b..f1d5824d9e6ec43b96da035ed6d102dc71713a1d 100644
--- a/components/gcm_driver/instance_id/instance_id.h
+++ b/components/gcm_driver/instance_id/instance_id.h
@@ -20,8 +20,8 @@ class InstanceIDHandler;
namespace instance_id {
// Encapsulates Instance ID functionalities that need to be implemented for
-// different platform. One instance is created per application. Life of
-// Instance ID is managed by the InstanceIdDriver.
+// different platforms. One instance is created per application. Life of
+// Instance ID is managed by the InstanceIDDriver.
class InstanceID {
public:
enum Result {
@@ -41,7 +41,8 @@ class InstanceID {
UNKNOWN_ERROR
};
- // Asynchronous callbacks.
+ // Asynchronous callbacks. Must not synchronously delete |this| (using
+ // InstanceIDDriver::RemoveInstanceID).
typedef base::Callback<void(const std::string& app_id,
bool update_id)> TokenRefreshCallback;
typedef base::Callback<void(const std::string& id)> GetIDCallback;

Powered by Google App Engine
This is Rietveld 408576698