Make InstanceIDBridge fully async to fix strict mode violations

components/gcm_driver/instance_id/instance_id.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_GCM_DRIVER_INSTANCE_ID_INSTANCE_ID_H_
 #define COMPONENTS_GCM_DRIVER_INSTANCE_ID_INSTANCE_ID_H_
 
 #include <map>
 #include <memory>
 #include <string>
 
 #include "base/callback.h"
 #include "base/macros.h"
 #include "base/time/time.h"
 
 namespace gcm {
 class InstanceIDHandler;
 }  // namespace gcm
 
 namespace instance_id {
 
 // Encapsulates Instance ID functionalities that need to be implemented for
-// different platform. One instance is created per application. Life of
-// Instance ID is managed by the InstanceIdDriver.
+// different platforms. One instance is created per application. Life of
+// Instance ID is managed by the InstanceIDDriver.
 class InstanceID {
  public:
   enum Result {
     // Successful operation.
     SUCCESS,
     // Invalid parameter.
     INVALID_PARAMETER,
     // Instance ID is disabled.
     DISABLED,
     // Previous asynchronous operation is still pending to finish.
     ASYNC_OPERATION_PENDING,
     // Network socket error.
     NETWORK_ERROR,
     // Problem at the server.
     SERVER_ERROR,
     // Other errors.
     UNKNOWN_ERROR
   };
 
-  // Asynchronous callbacks.
+  // Asynchronous callbacks. Must not synchronously delete this (using

[Peter Beverloo, 2016/04/27 10:56:37]

nit: reads slightly easier if you'd use |this| (zeh pipes)

[johnme, 2016/04/27 18:03:57]

Done.

+  // InstanceIDDriver::RemoveInstanceID).
   typedef base::Callback<void(const std::string& app_id,
                               bool update_id)> TokenRefreshCallback;
   typedef base::Callback<void(const std::string& id)> GetIDCallback;
   typedef base::Callback<void(const base::Time& creation_time)>
       GetCreationTimeCallback;
   typedef base::Callback<void(const std::string& token,
                               Result result)> GetTokenCallback;
   typedef base::Callback<void(Result result)> DeleteTokenCallback;
   typedef base::Callback<void(Result result)> DeleteIDCallback;
 
@@ skipping 58 matching lines @@
  private:
   std::string app_id_;
   TokenRefreshCallback token_refresh_callback_;
 
   DISALLOW_COPY_AND_ASSIGN(InstanceID);
 };
 
 }  // namespace instance_id
 
 #endif  // COMPONENTS_GCM_DRIVER_INSTANCE_ID_INSTANCE_ID_H_