Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1899743002: Remove unused FWL Panel code. (Closed)

Created:
4 years, 8 months ago by dsinclair
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused FWL Panel code. This code was used to subclass Form only, the one method in Panel is overridden in Form. Committed: https://pdfium.googlesource.com/pdfium/+/9b3656b8b49db7f228304aff9ffa599999199a0c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -113 lines) Patch
M BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M xfa.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M xfa/fwl/basewidget/fwl_comboboximp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_datetimepickerimp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_formproxyimp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/basewidget/fwl_tooltipctrlimp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M xfa/fwl/core/fwl_formimp.h View 4 chunks +3 lines, -4 lines 0 comments Download
M xfa/fwl/core/fwl_formimp.cpp View 4 chunks +16 lines, -13 lines 0 comments Download
M xfa/fwl/core/fwl_noteimp.cpp View 1 chunk +0 lines, -1 line 0 comments Download
D xfa/fwl/core/fwl_panelimp.h View 1 chunk +0 lines, -27 lines 0 comments Download
D xfa/fwl/core/fwl_panelimp.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
M xfa/fwl/core/ifwl_form.h View 2 chunks +2 lines, -2 lines 0 comments Download
D xfa/fwl/core/ifwl_panel.h View 1 chunk +0 lines, -21 lines 0 comments Download
M xfa/fwl/lightwidget/cfwl_tooltip.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL.
4 years, 8 months ago (2016-04-18 14:15:49 UTC) #2
Tom Sepez
lgtm
4 years, 8 months ago (2016-04-18 17:05:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899743002/1
4 years, 8 months ago (2016-04-18 17:20:40 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-18 17:21:04 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/9b3656b8b49db7f228304aff9ffa59999919...

Powered by Google App Engine
This is Rietveld 408576698