Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1899693004: Mention blacklist when gpu compositing or raster is disabled. (Closed)

Created:
4 years, 8 months ago by danakj
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mention blacklist when gpu compositing or raster is disabled. R=kbr@chromium.org BUG=600499 Committed: https://crrev.com/e7b47c93b032d2f1be1001bf22f2ccaaf064db95 Cr-Commit-Position: refs/heads/master@{#389293}

Patch Set 1 #

Patch Set 2 : blacklist: . #

Patch Set 3 : blacklist: rebase #

Patch Set 4 : blacklist: alltheblacklists #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -104 lines) Patch
M content/browser/gpu/compositor_util.cc View 1 2 3 1 chunk +73 lines, -104 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
danakj
I added "blacklist, " to gpu compositing, and gpu raster. Is there any others that ...
4 years, 8 months ago (2016-04-18 21:02:17 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899693004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899693004/20001
4 years, 8 months ago (2016-04-18 21:02:53 UTC) #3
Ken Russell (switch to Gerrit)
lgtm though it might be nice to improve the descriptions for the other blacklistable features ...
4 years, 8 months ago (2016-04-18 21:55:45 UTC) #5
danakj
On Mon, Apr 18, 2016 at 2:55 PM, <kbr@chromium.org> wrote: > lgtm though it might ...
4 years, 8 months ago (2016-04-18 21:57:20 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-18 22:14:38 UTC) #8
danakj
OK I added "via blacklist" to all the things that can be blacklisted.
4 years, 8 months ago (2016-04-22 22:15:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899693004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899693004/60001
4 years, 8 months ago (2016-04-22 22:16:19 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-22 23:17:43 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 23:19:16 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e7b47c93b032d2f1be1001bf22f2ccaaf064db95
Cr-Commit-Position: refs/heads/master@{#389293}

Powered by Google App Engine
This is Rietveld 408576698