Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1899643002: Rename ContainerNode method recalcChildStyle to recalcDescendantStyles (Closed)

Created:
4 years, 8 months ago by nainar
Modified:
4 years, 4 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename ContainerNode method recalcChildStyle to recalcDescendantStyles To make the name more accurate. This rename change was also mentioned in the Design Doc for splitting up Style Resolution and Layout Tree Construction here: https://drive.google.com/open?id=1RlEfhfUnhIEJSgV0nb8AKT4uyWbNsSY_k9uSGTUCQ2I BUG=595137 Committed: https://crrev.com/2e564841aa928e57bc364bf6b89fedd4bb572946 Cr-Commit-Position: refs/heads/master@{#408004}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rename recalcChildStyle -> recalcDescendantStyles #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/dom/ContainerNode.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (16 generated)
nainar
Sending to bring to your attention.
4 years, 8 months ago (2016-04-20 23:58:05 UTC) #3
nainar
@timloh, PTAl? This rename change was also mentioned in the Design Doc for splitting up ...
4 years, 8 months ago (2016-04-26 03:52:47 UTC) #6
Bugs Nash
lgtm
4 years, 8 months ago (2016-04-26 05:04:51 UTC) #7
Bugs Nash
On 2016/04/26 at 05:04:51, Bugs Nash wrote: > lgtm please add design doc link to ...
4 years, 8 months ago (2016-04-26 05:05:07 UTC) #8
nainar
Sending to @dstockwell for review.
4 years, 7 months ago (2016-05-10 03:36:15 UTC) #11
dstockwell
Not sure the new name is much better... Doesn't it recalc all descendants? Perhaps recalcDescendantStyles ...
4 years, 7 months ago (2016-05-10 03:48:54 UTC) #12
dstockwell
Not sure the new name is much better... Doesn't it recalc all descendants? Perhaps recalcDescendantStyles ...
4 years, 7 months ago (2016-05-10 03:48:54 UTC) #13
nainar
@dstockwell: Changed the name to recalcDescendantStyle. PTAL?
4 years, 7 months ago (2016-05-11 01:34:40 UTC) #14
nainar
@dstockwell/timloh, PTAL? Thanks!
4 years, 5 months ago (2016-07-21 01:28:46 UTC) #20
Timothy Loh
On 2016/07/21 01:28:46, nainar wrote: > @dstockwell/timloh, > > PTAL? > > Thanks! lgtm
4 years, 4 months ago (2016-07-26 06:57:42 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1899643002/40001
4 years, 4 months ago (2016-07-26 07:07:49 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/268979)
4 years, 4 months ago (2016-07-26 08:30:37 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/1899643002/40001
4 years, 4 months ago (2016-07-27 00:02:11 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-07-27 01:14:42 UTC) #29
commit-bot: I haz the power
4 years, 4 months ago (2016-07-27 01:16:49 UTC) #31
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2e564841aa928e57bc364bf6b89fedd4bb572946
Cr-Commit-Position: refs/heads/master@{#408004}

Powered by Google App Engine
This is Rietveld 408576698