🐝 Fix javac.py not running a change in a dependent library occurs

Fix javac.py not running a change in a dependent library occurs

BUG=604101
Committed: https://crrev.com/a386390aa48558ac05260bb264a625d08f00b21f
Cr-Commit-Position: refs/heads/master@{#388012}

[agrieve, 2016-04-18 14:27:04]

Description was changed from

==========
Fix javac.py not running a change in a dependent library occurs

BUG=604101
==========

to

==========
Fix javac.py not running a change in a dependent library occurs

BUG=604101
==========

[agrieve, 2016-04-18 14:27:04]

agrieve@chromium.org changed reviewers:
+ yfriedman@chromium.org

[agrieve, 2016-04-18 14:28:49]

On 2016/04/18 14:27:04, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:yfriedman@chromium.org

[Yaron, 2016-04-18 14:49:41]

https://codereview.chromium.org/1899633002/diff/1/build/android/gyp/javac.py
File build/android/gyp/javac.py (right):

https://codereview.chromium.org/1899633002/diff/1/build/android/gyp/javac.py#...
build/android/gyp/javac.py:355: if
options.classpath[0].endswith('.interface.jar'):
why do we only care about the first item? is it that we always receive either
interface jars or regular jars?

[agrieve, 2016-04-18 16:45:35]

https://codereview.chromium.org/1899633002/diff/1/build/android/gyp/javac.py
File build/android/gyp/javac.py (right):

https://codereview.chromium.org/1899633002/diff/1/build/android/gyp/javac.py#...
build/android/gyp/javac.py:355: if
options.classpath[0].endswith('.interface.jar'):
On 2016/04/18 14:49:41, Yaron wrote:
> why do we only care about the first item? is it that we always receive either
> interface jars or regular jars?

Right. That's what the comment on 358 is meant to capture. GYP uses .TOC files.
Once it's gone, this can just be deleted.

[Yaron, 2016-04-18 17:47:54]

lgtm

[agrieve, 2016-04-18 18:36:23]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-04-18 18:37:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1899633002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1899633002/1

[commit-bot: I haz the power, 2016-04-18 20:55:53]

Description was changed from

==========
Fix javac.py not running a change in a dependent library occurs

BUG=604101
==========

to

==========
Fix javac.py not running a change in a dependent library occurs

BUG=604101
==========

[commit-bot: I haz the power, 2016-04-18 20:55:54]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-18 20:57:17]

Description was changed from

==========
Fix javac.py not running a change in a dependent library occurs

BUG=604101
==========

to

==========
Fix javac.py not running a change in a dependent library occurs

BUG=604101

Committed: https://crrev.com/a386390aa48558ac05260bb264a625d08f00b21f
Cr-Commit-Position: refs/heads/master@{#388012}
==========

[commit-bot: I haz the power, 2016-04-18 20:57:18]

Patchset 1 (id:??) landed as
https://crrev.com/a386390aa48558ac05260bb264a625d08f00b21f
Cr-Commit-Position: refs/heads/master@{#388012}