Issue 189963007: Use isHTML*Element() helpers more in the accessibility code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 189963007: Use isHTML*Element() helpers more in the accessibility code (Closed)

Created:
6 years, 9 months ago by Inactive

Modified:
6 years, 9 months ago

Reviewers:
esprehn, adamk, eseidel

CC:
blink-reviews, dmazzoni, aboxhall

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Use isHTML*Element() helpers more in the accessibility code Use isHTML*Element() helpers more in the accessibility code for clarity. This CL also updates the isHTML*Element() helpers to accept a null pointer argument instead of asserting. This seems a bit more convenient. R=esprehn, adamk BUG=346095 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168772

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+108 lines, -118 lines)			Patch
M	Source/build/scripts/templates/ElementTypeHelpers.h.tmpl	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/accessibility/AXListBoxOption.cpp	View	3 chunks	+5 lines, -8 lines	0 comments	Download
M	Source/core/accessibility/AXMediaControls.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/accessibility/AXNodeObject.cpp	View	20 chunks	+69 lines, -72 lines	0 comments	Download
M	Source/core/accessibility/AXObjectCache.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/accessibility/AXRenderObject.cpp	View	10 chunks	+28 lines, -32 lines	0 comments	Download
M	Source/core/accessibility/AXTable.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/189963007/1

6 years, 9 months ago (2014-03-07 23:17:46 UTC) #3

Message was sent while issue was closed.

Change committed as 168772

Expand Messages | Collapse Messages