QUIC - histograms to measure the time spent to read QUIC sever

net/quic/quic_crypto_client_stream.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_QUIC_CRYPTO_CLIENT_STREAM_H_
 #define NET_QUIC_QUIC_CRYPTO_CLIENT_STREAM_H_
 
 #include <string>
 
 #include "base/memory/weak_ptr.h"
+#include "base/time/time.h"
 #include "net/cert/cert_verify_result.h"
 #include "net/cert/x509_certificate.h"
 #include "net/quic/crypto/proof_verifier.h"
 #include "net/quic/crypto/quic_crypto_client_config.h"
 #include "net/quic/quic_config.h"
 #include "net/quic/quic_crypto_stream.h"
 
 namespace net {
 
 class ProofVerifyDetails;
@@ skipping 107 matching lines @@
   string verify_error_details_;
   scoped_ptr<ProofVerifyDetails> verify_details_;
 
   // The result of certificate verification.
   scoped_ptr<CertVerifyResult> cert_verify_result_;
 
   // This member is used to store the result of an asynchronous disk cache read.
   // It must not be used after STATE_LOAD_QUIC_SERVER_INFO_COMPLETE.
   int disk_cache_load_result_;
 
+  // Time when call to WaitForDataReady was made, used for computing time spent
+  // to read QUIC server information from disk cache.
+  base::TimeTicks read_start_time_;

[wtc, 2014/03/10 17:29:28]

Nit: this variable is poorly named because "read" can also mean "reading from
the network".

I suggest renaming it "disk_cache_load_start_time_" (see
"disk_cache_load_result_" above) or "disk_cache_read_start_time_".

[ramant (doing other things), 2014/03/10 20:42:20]

Renamed the variable in https://codereview.chromium.org/192583005/

Thanks Wan-Teh.
Done.

+
   base::WeakPtrFactory<QuicCryptoClientStream> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicCryptoClientStream);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_CRYPTO_CLIENT_STREAM_H_